bench(hj): Add missing Q16–Q23 to benchmarks#23257
Merged
Merged
Conversation
LiaCastaneda
force-pushed
the
bench/hj-extend-q16-q23
branch
3 times, most recently
from
c1612e8 to
8d00b68
Compare
LiaCastaneda
force-pushed
the
bench/hj-extend-q16-q23
branch
from
8d00b68 to
cad83e3
Compare
LiaCastaneda
changed the title
Dandandan
reviewed
Jun 30, 2026
Dandandan
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Adds benchmark query for #23237
Useful to test changes in #23209
Rationale for this change
Q16–Q22 existed in
hj.rsbut were missing.benchmarkfiles, so they were invisible tobench.shand the CI benchmark bot. Q23 is a new query reproducing a skewed high-fanout pattern where a single partition does nearly all the join work -- almost all probe rows carry the same key. Statistics are disabled to forcePartitionedmode.What changes are included in this PR?
benchmarks/src/hj.rs: adds Q23benchmarks/sql_benchmarks/hj/benchmarks/q16–q23.benchmark: sql harness files for Q16–Q23 so they run viabench.shand the CI benchmark botAre these changes tested?
These are benchmark additions, so no tests are needed.
Are there any user-facing changes?
No